Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d963be7219adf39702f65263029f1b0bf09782d
https://github.com/WebKit/WebKit/commit/6d963be7219adf39702f65263029f1b0bf09782d
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Tools/TestWebKitAPI/Tests/WGSL/MetalCompilationTests.mm
M Tools/TestWebKitAPI/Tests/WGSL/TestWGSLAPI.h
Log Message:
-----------
[WebGPU][WGSL] Three or more inlined calls to one function over a 256-byte
struct silently miscompile on iOS
https://bugs.webkit.org/show_bug.cgi?id=323560
rdar://186804865
Reviewed by Dan Glastonbury.
Instead of using always_inline which causes miscompilations on Apple9 devices,
allow the compiler to decide whether or not to perform the inlining.
Tests: Tools/TestWebKitAPI/Tests/WGSL/MetalCompilationTests.mm
Tools/TestWebKitAPI/Tests/WGSL/TestWGSLAPI.h
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::shouldForceInlining const):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Tools/TestWebKitAPI/Tests/WGSL/MetalCompilationTests.mm:
(TestWGSLAPI::testCompilationForAppleGPUFamily):
(TestWGSLAPI::TEST_F(WGSLMetalCompilationTests, InlineLargeAggregateReturns)):
* Tools/TestWebKitAPI/Tests/WGSL/TestWGSLAPI.h:
(TestWGSLAPI::generate):
Canonical link: https://commits.webkit.org/320697@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
