Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7468b6444dc1bb6669a9cd4476073d54ad1b52be
https://github.com/WebKit/WebKit/commit/7468b6444dc1bb6669a9cd4476073d54ad1b52be
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
A
LayoutTests/accessibility/isolated-tree/mac/setting-attributes-is-asynchronous-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/setting-attributes-is-asynchronous.html
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
Log Message:
-----------
AX: setting-attributes-is-asynchronous.html fails in isolated tree mode
because takeFocus() waits
https://bugs.webkit.org/show_bug.cgi?id=323535
rdar://186773197
Reviewed by Chris Fleizach and Dominic Mazzoni.
The test asserts that setting an accessibility attribute doesn't block the
caller, by focusing a text
field and checking that the line printed after takeFocus() comes before the one
its onfocus handler
prints. It got them the other way around in isolated tree mode.
takeFocus() went through setAttributeValue(), which dispatches with
executeOnAXThreadAndWait() and
spins the main run loop until the accessibility thread is done. Focus was
therefore taken, and the
handler had run, before takeFocus() returned.
Change AccessibilityUIElementMac::takeFocus to dispatch without waiting,
similar to how every
other non-AXSync prefixed action works.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
*
LayoutTests/accessibility/isolated-tree/mac/setting-attributes-is-asynchronous-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/mac/setting-attributes-is-asynchronous.html:
Added.
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElementMac::takeFocus):
Canonical link: https://commits.webkit.org/320702@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
