Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f7bc716873fa5f84176a2d38ff00567f49c40c7
https://github.com/WebKit/WebKit/commit/5f7bc716873fa5f84176a2d38ff00567f49c40c7
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Tools/TestWebKitAPI/Tests/WGSL/shaders/array-alias-constructor.wgsl
M Tools/TestWebKitAPI/Tests/WGSL/shaders/array-vec3.wgsl
Log Message:
-----------
[WebGPU][WGSL] Array value constructor named through a type alias emits
invalid MSL, silently producing wrong compute results
https://bugs.webkit.org/show_bug.cgi?id=323543
rdar://186803296
Reviewed by Dan Glastonbury.
Ensure arrays via type aliases are correctly handled to
avoid miscompilations.
Tests: Tools/TestWebKitAPI/Tests/WGSL/shaders/array-alias-constructor.wgsl
Tools/TestWebKitAPI/Tests/WGSL/shaders/array-vec3.wgsl
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::packArrayResource):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Tools/TestWebKitAPI/Tests/WGSL/shaders/array-alias-constructor.wgsl:
* Tools/TestWebKitAPI/Tests/WGSL/shaders/array-vec3.wgsl:
Canonical link: https://commits.webkit.org/320690@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
