Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4671d8f9fbe2e69f99250dc96411953658bc8980
https://github.com/WebKit/WebKit/commit/4671d8f9fbe2e69f99250dc96411953658bc8980
Author: Sergio Villar Senin <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_optional_offsetRay.https-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_optional_offsetRay.https.html
M Source/WebCore/Modules/webxr/XRHitTestOptionsInit.idl
M Source/WebCore/Modules/webxr/XRTransientInputHitTestOptionsInit.idl
Log Message:
-----------
REGRESSION(r311167): It made hit testing fail whenever offsetRay was not
specified
https://bugs.webkit.org/show_bug.cgi?id=323656
Reviewed by Anne van Kesteren and Dan Glastonbury.
311167@main broke hit testing because it added
[ImplementationDefaultValue=null] to offsetRay which is not a nullable
dictionary member (it's simply optional). When offsetRay was not
specified (and considering that a default null value was declared) then
JSToWrappedOverloader<WebXRRay>::toWrapped() converted the undefined
from the dictionary into a nullptr which causes JSDOMCovertInterface to
throw a TypeError (because a missing wrapper is considered as an error).
We are adding a new WPT test that properly detects whether the absence
of optional parameters passed to request(Transient)HitTestSource do not
trigger exceptions.
Tests:
imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_optional_offsetRay.https.html
* Source/WebCore/Modules/webxr/XRHitTestOptionsInit.idl:
* Source/WebCore/Modules/webxr/XRTransientInputHitTestOptionsInit.idl:
*
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_optional_offsetRay.https-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/webxr/hit-test/ar_hittest_subscription_optional_offsetRay.https.html:
Added.
Canonical link: https://commits.webkit.org/320717@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
