Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 64fc61df74c24ae134b9874c55f20d5764f71c22
https://github.com/WebKit/WebKit/commit/64fc61df74c24ae134b9874c55f20d5764f71c22
Author: Kiara Rose <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
Log Message:
-----------
1Password: popover is cut off, cannot access sign in
https://bugs.webkit.org/show_bug.cgi?id=323683
rdar://186391990
Reviewed by Timothy Hatcher.
The 1Password popup is cut off, preventing users from signing in. Its popup is
laid out in viewport
units and vh, svh, lvh all resolve to minimumPopoverHeight (50pt) rather than
the popup's actual
size: passing CGSizeZero for the maximumUnobscuredSizeOverride leaves vh and
lvh to fall back
to the collapsed layout size, and svh gets it directly via minimumLayoutSize.
To fix this, pass the popup's desired size for both
minimumUnobscuredSizeOverride and
maximumUnobscuredSizeOverride, since a popover has no dynamic UI to retract and
the height for all
of these values should be the actual size.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionViewController _updatePopoverContentSize]):
Canonical link: https://commits.webkit.org/320726@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
