Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b28aef30d8c0c4f13e7e70fba91ba9287e61d735
https://github.com/WebKit/WebKit/commit/b28aef30d8c0c4f13e7e70fba91ba9287e61d735
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
A
LayoutTests/accessibility/isolated-tree/mac/search-predicate-from-ignored-element-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/search-predicate-from-ignored-element.html
M Source/WebCore/accessibility/AXTextMarker.cpp
Log Message:
-----------
AX: In isolated tree mode, a br after an inline-block is left out of the
line's range
https://bugs.webkit.org/show_bug.cgi?id=323726
rdar://186974686
Reviewed by Dominic Mazzoni.
For markup like this:
<div>First line of text<br><button
aria-hidden="true">button</button><br>Third line</div>
AXLineTextMarkerRangeForTextMarker returned "button" for the button's line
rather than
"button\n", losing the newline the trailing br contributes.
An AXTextRunLineID is a (containing block, line index) pair. The button's text
lays out in
the button's own anonymous block while the br after it lays out in the div, so
the two
never compare equal and AXTextMarker::findLine's walk stops at the lineID
change without
ever reaching the br.
When walking forwards for a line end and the next object with runs is a line
break in a
different containing block, take its end position.
Makes search-predicate-from-ignored-element.html pass in ITM, since that
test dumped the string value of its search results, which differed due
to this bug.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
*
LayoutTests/accessibility/isolated-tree/mac/search-predicate-from-ignored-element-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/mac/search-predicate-from-ignored-element.html:
Added.
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::findLine const):
Canonical link: https://commits.webkit.org/320728@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
