Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a6509b7967f0b7b8d8c03b2b16cc7801b9ffa01f
https://github.com/WebKit/WebKit/commit/a6509b7967f0b7b8d8c03b2b16cc7801b9ffa01f
Author: Alejandro G. Castro <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp
M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
M Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp
M Source/WebCore/svg/SVGFEDropShadowElement.cpp
M Source/WebCore/svg/SVGFELightElement.cpp
M Source/WebCore/svg/SVGFESpecularLightingElement.cpp
M Source/WebCore/svg/SVGFETurbulenceElement.cpp
M Source/WebCore/svg/properties/SVGAnimatedPrimitivePropertyAccessor.h
M Source/WebCore/svg/properties/SVGAnimatedPropertyAccessorImpl.h
M Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessor.h
M Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessorImpl.h
M Source/WebCore/svg/properties/SVGPropertyOwnerRegistry.h
Log Message:
-----------
SVG property registry should not take the initial value as a non-type
template parameter
https://bugs.webkit.org/show_bug.cgi?id=323357
Reviewed by Said Abou-Hallawa.
320226@main started storing each SVGAnimatedInteger and SVGAnimatedNumber
attribute's initial value on its accessor, and passed it as a non-type template
parameter alongside the property. On the other hand initialValue does not need
to be a template parameter. The singleton is already unique per property, and a
property is registered exactly once.
This patch is a simplification of the original without changing the idea behind
the original patch. We detected this issue compiling for and older Android NDK.
No behaviour change so original tests should check if the patch is
correct.
* Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::PropertyRegistry::registerProperties):
* Source/WebCore/svg/properties/SVGAnimatedPrimitivePropertyAccessor.h:
* Source/WebCore/svg/properties/SVGAnimatedPropertyAccessorImpl.h:
* Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessor.h:
* Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessorImpl.h:
* Source/WebCore/svg/properties/SVGPropertyOwnerRegistry.h:
Canonical link: https://commits.webkit.org/320736@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
