Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 420444d03f4574b9eb50fd17c72b8cc4e1c2e7b9
https://github.com/WebKit/WebKit/commit/420444d03f4574b9eb50fd17c72b8cc4e1c2e7b9
Author: David Kilzer <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
Log Message:
-----------
REGRESSION (320694@main): DownloadCocoa.mm fails to build: inline function
'IPC::MessageSender::send' is not defined
<https://bugs.webkit.org/show_bug.cgi?id=323756>
<rdar://187017136>
Unreviewed build fix.
Add `#import "MessageSenderInlines.h"` to `DownloadCocoa.mm`.
`Download` derives from `IPC::MessageSender` and calls `send()` and
`sendWithAsyncReply()` with `Messages::DownloadProxy` messages, whose
inline function templates are declared in `MessageSender.h` but
defined in `MessageSenderInlines.h`. `DownloadCocoa.mm` did not
include that header and compiled only because a preceding sibling in
its unified-source bundle did, leaking the definitions forward through
the translation unit.
320694@main regrouped the unified-source bundles so that no preceding
sibling provides those definitions, leaving the calls with
declared-but-undefined inline templates: a `-Werror,-Wundefined-inline`
compile error in Debug builds and an undefined-symbol link error in
Release and ASan builds.
* Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
Canonical link: https://commits.webkit.org/320733@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
