Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d4ba76464422865075d4f62aaebd9825c3b6338b
https://github.com/WebKit/WebKit/commit/d4ba76464422865075d4f62aaebd9825c3b6338b
Author: Brent Fulgham <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm
M Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
Log Message:
-----------
[Cocoa] Update key handling for WebDriver to match Chrome and other WebKit
ports
https://bugs.webkit.org/show_bug.cgi?id=323705
rdar://186961436
Reviewed by BJ Burg.
The "*Right" variants of key inputs were not being handled properly in
WebAutomationSession::charCodeForVirtualKey(...) in Cocoa, though this was
already properly
implemented in GTK/WPE.
This patch corrects these code paths so that we improve WPT scores in keyboard
handling and
set the groundwork for a follow-up patch to address the remaining failures.
That follow
up will also correct iOS more completely, as it lacks some context needed to
properly
pass WPT tests at present.
This change moves the key_events.py test from 67/93 to 87/93.
Tests: webdriver/tests/classic/perform_actions/key_events.py
* Source/WebKit/UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:
(WebKit::WebAutomationSession::charCodeForVirtualKey const):
* Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::keyCodeForCharKey):
(WebKit::keyCodeForVirtualKey):
(WebKit::eventModifierFlagsForVirtualKey):
Canonical link: https://commits.webkit.org/320741@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
