Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 86b750ce03c87c313fd9c70593e71efc7e5dd4f3
https://github.com/WebKit/WebKit/commit/86b750ce03c87c313fd9c70593e71efc7e5dd4f3
Author: Aakash Jain <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Tools/CISupport/Shared/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Cancelled test build is incorrectly reported as green
https://bugs.webkit.org/show_bug.cgi?id=323685
rdar://162612734
Reviewed by Ryan Haddad.
SetBuildSummary forced the build result to SUCCESS whenever the build_summary
property matched one of its success messages. That property is set
optimistically
by the first test step that passes, and later test steps only overwrite it once
they reach a verdict. Cancelling a build in between (for example after
run-layout-tests-in-stress-mode passed but while layout-tests was still being
retried) left the stale "Passed layout tests" summary in place, and
SetBuildSummary then overrode the CANCELLED build result with SUCCESS, so the
build appeared green even though tests were failing.
Leave the build result alone for builds which were cancelled or are being
retried, since those never reached a verdict, and report the interruption as the
build summary instead.
* Tools/CISupport/Shared/steps.py:
(SetBuildSummary.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestFilterLayoutTestFailuresUsingResultsDB.test_set_build_summary_keeps_a_cancelled_build_cancelled):
Canonical link: https://commits.webkit.org/320761@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
