Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a86a48dc43ceb3a4c3faab7c7504288462cf159d
https://github.com/WebKit/WebKit/commit/a86a48dc43ceb3a4c3faab7c7504288462cf159d
Author: Antti Koivisto <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/values/flexbox/StyleFlexBasis.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericOrKeyword+CSSValueConversion.h
A
Source/WebCore/style/values/primitives/StyleSizeOrKeyword+CSSValueConversion.h
A Source/WebCore/style/values/primitives/StyleSizeOrKeyword.h
M Source/WebCore/style/values/sizing/StyleMaximumSize.h
M Source/WebCore/style/values/sizing/StyleMinimumSize.h
M Source/WebCore/style/values/sizing/StylePreferredSize.h
Log Message:
-----------
[css-values-5 calc-size()] Add SizeOrKeyword<> style type base
https://bugs.webkit.org/show_bug.cgi?id=323759
rdar://187019453
Reviewed by Sam Weinig.
Only size style types like Style::PreferredSize support calc-size(). Introduce
SizeOrKeyword<> base type to use for those and remove the code from
PrimitiveNumericOrKeyword<>.
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/values/flexbox/StyleFlexBasis.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericOrKeyword+CSSValueConversion.h:
(WebCore::Style::convertPrimitiveNumericOrKeywordFromCSSValue):
(WebCore::Style::NumericOrKeywordCSSValueConversion::invalidValue):
(WebCore::Style::NumericOrKeywordCSSValueConversion::operator()):
(WebCore::Style::convertCalcSizeForCSSValueConversion): Deleted.
(WebCore::Style::CSSValueConversion<StyleType>::operator()): Deleted.
IsBaseOfTemplate follows indirect bases, so the size types still satisfy
LengthPercentageOrKeywordDerived and this specialization has to exclude them
explicitly.
*
Source/WebCore/style/values/primitives/StyleSizeOrKeyword+CSSValueConversion.h:
Added.
(WebCore::Style::convertCalcSizeForCSSValueConversion):
(WebCore::Style::CSSValueConversion<StyleType>::operator()):
* Source/WebCore/style/values/primitives/StyleSizeOrKeyword.h: Added.
* Source/WebCore/style/values/sizing/StyleMaximumSize.h:
* Source/WebCore/style/values/sizing/StyleMinimumSize.h:
* Source/WebCore/style/values/sizing/StylePreferredSize.h:
Canonical link: https://commits.webkit.org/320763@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
