Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0f31212799440abd778e7bdcb0ad2af0f0f4b95e
https://github.com/WebKit/WebKit/commit/0f31212799440abd778e7bdcb0ad2af0f0f4b95e
Author: Chris Dumez <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WTF/wtf/ThreadAssertions.h
M Source/WebCore/css/CSSStyleSheet.cpp
M Source/WebCore/css/CSSStyleSheet.h
M Source/WebCore/dom/Attr.cpp
M Source/WebCore/dom/Attr.h
M Source/WebCore/dom/TreeWalker.cpp
M Source/WebCore/dom/TreeWalker.h
M Source/WebCore/html/HTMLCollection.cpp
M Source/WebCore/html/HTMLCollection.h
M Source/WebCore/html/HTMLCollectionInlines.h
M Source/WebCore/html/track/TextTrackCue.cpp
M Source/WebCore/html/track/TextTrackCue.h
M Source/WebCore/xml/XSLStyleSheet.h
Log Message:
-----------
Adopt WTF_DECLARE_OWNER_THREAD_ASSERTIONS in the remaining owner-thread
classes
https://bugs.webkit.org/show_bug.cgi?id=323736
Reviewed by Geoffrey Garen.
320637@main annotated six classes by naming the lock and the owner thread at
each unlocked
read, and 320703@main then added WTF_DECLARE_OWNER_THREAD_ASSERTIONS() and used
it for Range,
leaving two spellings of the same thing in the tree. Declare the assertions in
the other six
classes too and collapse their twenty-two call sites to assertIsOwnerThread(),
which states
the choice of owner once per class instead of once per read. CSSStyleSheet.h,
HTMLCollection.h
and TextTrackCue.h gain an explicit <wtf/ThreadAssertions.h>: they had been
picking the free
function up transitively through their implementation files, which no longer
suffices now that
the macro expands in the header.
* Source/WTF/wtf/ThreadAssertions.h:
* Source/WebCore/css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::ownerNode const):
(WebCore::CSSStyleSheet::isDetached const):
* Source/WebCore/css/CSSStyleSheet.h:
* Source/WebCore/dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::style):
(WebCore::Attr::value const):
* Source/WebCore/dom/Attr.h:
* Source/WebCore/dom/TreeWalker.cpp:
* Source/WebCore/dom/TreeWalker.h:
* Source/WebCore/html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItemSlow const):
(WebCore::HTMLCollection::supportedPropertyNames):
(WebCore::HTMLCollection::isSupportedPropertyName):
(WebCore::HTMLCollection::namedItems const):
* Source/WebCore/html/HTMLCollection.h:
* Source/WebCore/html/HTMLCollectionInlines.h:
(WebCore::HTMLCollection::hasNamedElementCache const):
* Source/WebCore/html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::track const):
* Source/WebCore/html/track/TextTrackCue.h:
* Source/WebCore/xml/XSLStyleSheet.h:
Canonical link: https://commits.webkit.org/320789@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
