Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bc5bc3c2d6c3e7ae68eae2078b3989696ad18a8a
https://github.com/WebKit/WebKit/commit/bc5bc3c2d6c3e7ae68eae2078b3989696ad18a8a
Author: John James Jacoby <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[Win][CMake] Forward MSVC-style definitions to Swift
https://bugs.webkit.org/show_bug.cgi?id=323791
Reviewed by Adrian Taylor.
The Swift Clang importer must use the same preprocessor definitions as C++
translation units. The helper that collects definitions from CMake compiler
flags recognizes GCC-style -D options, but Windows CMake flags use MSVC-style
/D options. This drops NDEBUG from Windows Release Swift imports and gives
Swift and C++ incompatible views of assertion-dependent types.
Recognize both attached and separated /D options and normalize them to -D
before forwarding them to the importer.
* Source/cmake/WebKitMacros.cmake:
(_webkit_cxx_preprocessor_definitions):
Canonical link: https://commits.webkit.org/320804@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
