Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cfec12e9a25e4b98f1602639cbc88b17a712c77a
https://github.com/WebKit/WebKit/commit/cfec12e9a25e4b98f1602639cbc88b17a712c77a
Author: Yusuke Suzuki <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M LayoutTests/TestExpectations
R LayoutTests/fast/dom/gc-8-expected.txt
R LayoutTests/fast/dom/gc-8.html
M Source/WebCore/bindings/js/GarbageCollectionController.cpp
M Source/WebCore/bindings/js/GarbageCollectionController.h
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h
M Source/WebKitLegacy/mac/Misc/WebCoreStatistics.h
M Source/WebKitLegacy/mac/Misc/WebCoreStatistics.mm
M Tools/DumpRenderTree/GCController.cpp
M Tools/DumpRenderTree/GCController.h
M Tools/DumpRenderTree/mac/GCControllerMac.mm
M Tools/WebKitTestRunner/InjectedBundle/Bindings/GCController.idl
M Tools/WebKitTestRunner/InjectedBundle/GCController.cpp
M Tools/WebKitTestRunner/InjectedBundle/GCController.h
Log Message:
-----------
Remove broken debugging helper "collectOnAlternateThread"
https://bugs.webkit.org/show_bug.cgi?id=323790
rdar://186773323
Reviewed by Yijia Huang.
"collectOnAlternateThread" is a debugging helper function exposed in
DumpRenderTree / WebKitTestRunner. But its implementation and feature is
broken: we cannot run GC from random alternate thread, and this never
happens. This patch removes this helper function and also removes broken
test, which is already skipped.
* LayoutTests/TestExpectations:
* LayoutTests/fast/dom/gc-8-expected.txt: Removed.
* LayoutTests/fast/dom/gc-8.html: Removed.
* Source/WebCore/bindings/js/GarbageCollectionController.cpp:
(WebCore::GarbageCollectionController::gcTimerFired):
(WebCore::collect): Deleted.
(WebCore::GarbageCollectionController::garbageCollectOnAlternateThreadForDebugging):
Deleted.
* Source/WebCore/bindings/js/GarbageCollectionController.h:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
Deleted.
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h:
* Source/WebKitLegacy/mac/Misc/WebCoreStatistics.h:
* Source/WebKitLegacy/mac/Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics
garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging:]): Deleted.
* Tools/DumpRenderTree/GCController.cpp:
(GCController::createJSClass):
(collectOnAlternateThreadCallback): Deleted.
* Tools/DumpRenderTree/GCController.h:
* Tools/DumpRenderTree/mac/GCControllerMac.mm:
(GCController::collectOnAlternateThread const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
* Tools/WebKitTestRunner/InjectedBundle/GCController.cpp:
(WTR::GCController::collectOnAlternateThread): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/GCController.h:
Canonical link: https://commits.webkit.org/320798@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
