Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad8fd867b57c4f0c8b63abdd773cca615e434f78
https://github.com/WebKit/WebKit/commit/ad8fd867b57c4f0c8b63abdd773cca615e434f78
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/WGSLShaderModule.h
M Tools/TestWebKitAPI/Tests/WGSL/MetalCompilationTests.mm
Log Message:
-----------
Add missing validation for overrides
https://bugs.webkit.org/show_bug.cgi?id=323806
rdar://185268723
Reviewed by Dan Glastonbury.
Add missing validation to avoid override misuse.
Test: Tools/TestWebKitAPI/Tests/WGSL/MetalCompilationTests.mm
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::skipsRightHandSide):
(WGSL::RewriteGlobalVariables::addOverrideValidation):
(WGSL::RewriteGlobalVariables::pack):
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
* Tools/TestWebKitAPI/Tests/WGSL/MetalCompilationTests.mm:
(TestWGSLAPI::expectNoGenerateError):
(TestWGSLAPI::TEST_F(WGSLMetalCompilationTests, OverrideShortCircuit)):
Canonical link: https://commits.webkit.org/320829@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
