Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0e84b2439008e6b253a2e6facb2b2b9bf91157a2
https://github.com/WebKit/WebKit/commit/0e84b2439008e6b253a2e6facb2b2b9bf91157a2
Author: Alex Christensen <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
R LayoutTests/ipc/loadping-firstpartyforcookies-message-check-expected.txt
R LayoutTests/ipc/loadping-firstpartyforcookies-message-check.html
M Source/WebCore/loader/LoaderStrategy.cpp
M Source/WebCore/loader/LoaderStrategy.h
M Source/WebCore/loader/PingLoader.cpp
M Source/WebCore/loader/PingLoader.h
M Source/WebCore/loader/ResourceLoader.cpp
M Source/WebCore/loader/ResourceLoader.h
M Source/WebCore/loader/cache/CachedResource.cpp
M Source/WebCore/loader/cache/CachedResource.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkSession.cpp
R Source/WebKit/NetworkProcess/PingLoad.cpp
R Source/WebKit/NetworkProcess/PingLoad.h
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.h
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h
M Tools/TestWebKitAPI/Tests/WebCore/TestPlatformStrategies.cpp
Log Message:
-----------
Remove PingLoad
https://bugs.webkit.org/show_bug.cgi?id=323795
rdar://187045715
Reviewed by Youenn Fablet.
PingLoad was already unused because of the existing call to usePingLoad,
which turned it off for WebKit but kept PingHandle on for WebKitLegacy.
This PR uses PingHandle for WebKitLegacy to keep existing behavior, but
it does so through a new function startKeepAliveLoadForWebKitLegacy
so that we can remove lots of unreachable code from WebKit.
Test: Tools/TestWebKitAPI/Tests/WebCore/TestPlatformStrategies.cpp
* Source/WebCore/loader/LoaderStrategy.h:
* Source/WebCore/loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* Source/WebCore/loader/PingLoader.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::startKeepAliveLoadForWebKitLegacy):
* Source/WebCore/loader/ResourceLoader.h:
* Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* Source/WebCore/loader/cache/CachedResource.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
* Source/WebKit/NetworkProcess/PingLoad.cpp: Removed.
* Source/WebKit/NetworkProcess/PingLoad.h: Removed.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didFinishPingLoad): Deleted.
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.h:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in:
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad): Deleted.
(WebKit::WebLoaderStrategy::didFinishPingLoad): Deleted.
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.h:
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::startKeepAliveLoadForWebKitLegacy):
(WebResourceLoadScheduler::startPingLoad): Deleted.
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h:
* Tools/TestWebKitAPI/Tests/WebCore/TestPlatformStrategies.cpp:
* LayoutTests/ipc/loadping-firstpartyforcookies-message-check-expected.txt:
Removed.
* LayoutTests/ipc/loadping-firstpartyforcookies-message-check.html: Removed.
* Source/WebCore/loader/LoaderStrategy.cpp:
(WebCore::LoaderStrategy::startKeepAliveLoadForWebKitLegacy):
Canonical link: https://commits.webkit.org/320831@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
