Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 81f7a618cee3d34485aa4fb70fa8efdd37431528
https://github.com/WebKit/WebKit/commit/81f7a618cee3d34485aa4fb70fa8efdd37431528
Author: Tyler Wilcock <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
A
LayoutTests/accessibility/isolated-tree/mac/text-marker-p-tags-expected.txt
A LayoutTests/accessibility/isolated-tree/mac/text-marker-p-tags.html
M Source/WebCore/accessibility/AXTextMarker.cpp
Log Message:
-----------
AX: In isolated tree mode, backwards word and sentence navigation fail to
leave a paragraph
https://bugs.webkit.org/show_bug.cgi?id=323701
rdar://186957255
Reviewed by Dominic Mazzoni.
AXTextMarker::findWordOrSentence walks objects with text runs in the search
direction,
flattening their text so the word and sentence break iterators have enough
context, and
stopped as soon as the containing block changed. That means a marker at the
start of a
paragraph never saw the paragraph before it, so
AXPreviousWordStartTextMarkerForTextMarker
and AXPreviousSentenceStartTextMarkerForTextMarker returned the marker they
were given, and
VoiceOver couldn't move backwards by word or sentence past the start of a block.
With this commit, we let the backwards walk cross a containing-block change,
joining the two
blocks' text with the newline they render as, so the break iterators don't run
the last word
of one paragraph into the first word of the next.
Makes text-marker-p-tags.html pass in ITM.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/isolated-tree/mac/text-marker-p-tags-expected.txt:
Added.
* LayoutTests/accessibility/isolated-tree/mac/text-marker-p-tags.html: Added.
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::findWordOrSentence const):
Canonical link: https://commits.webkit.org/320840@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
