Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 257af3cb70fe470d267072c69f1015d92e78ae73
https://github.com/WebKit/WebKit/commit/257af3cb70fe470d267072c69f1015d92e78ae73
Author: Ruthvik Konda <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/comments-expected.txt
M Source/WebGPU/WGSL/Lexer.cpp
Log Message:
-----------
[WGSL] shader,validation,parse,comments:* is failing
https://bugs.webkit.org/show_bug.cgi?id=323826
rdar://187062124
Reviewed by Mike Wyrzykowski and Dan Glastonbury.
The WGSL spec[1] defines a line break as any of line feed, vertical tab, form
feed, carriage return, next line, line separator or paragraph separator, and a
line-ending comment runs up to but not including the next line break. We only
stopped at line feed, so a comment ended by any of the others swallowed the rest
of the physical line, silently accepting code that should have been rejected.
[1]: https://www.w3.org/TR/WGSL/#blankspace-and-line-breaks
*
LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/comments-expected.txt:
* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::isLineBreak):
(WGSL::Lexer<T>::skipLineComment):
Canonical link: https://commits.webkit.org/320849@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
