Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d11d7774b7af120d973abc019a54751ab1890cbd
https://github.com/WebKit/WebKit/commit/d11d7774b7af120d973abc019a54751ab1890cbd
Author: Alan Baradlay <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp
M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
M Source/WebCore/rendering/RenderLineBoxList.cpp
M Source/WebCore/rendering/svg/RenderSVGInline.cpp
M Source/WebCore/rendering/svg/RenderSVGInline.h
Log Message:
-----------
[cleanup] Move the legacy line boxes from RenderInline to RenderSVGInline,
the only inline box that has them
https://bugs.webkit.org/show_bug.cgi?id=323672
<rdar://problem/186920347>
Reviewed by Antti Koivisto.
RenderInline has a RenderLineBoxList that only SVG can ever populate.
Move it and all of its accessors - legacyLineBoxes(), createInlineFlowBox(),
createAndAppendInlineFlowBox(), deleteLegacyLineBoxes(),
firstLegacyInlineBox(), lastLegacyInlineBox()
and dirtyLineFromChangedChild() - to RenderSVGInline, and retarget the external
users in LegacyLineLayout, LegacyInlineFlowBox and InlineIteratorInlineBox to
it.
No change in behavior.
* Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp:
(WebCore::InlineIterator::lineLeftmostInlineBoxFor):
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::removeLineBoxFromRenderObject):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::LegacyLineLayout::createLineBoxes):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::firstLegacyInlineBoxFor):
(WebCore::lastLegacyInlineBoxFor):
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::firstInlineBoxTopLeft):
(WebCore::RenderInline::innerPaddingBoxWidth):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRect):
(WebCore::RenderInline::offsetForInFlowPositionedInline):
(WebCore::RenderInline::willBeDestroyed): Deleted.
(WebCore::RenderInline::deleteLegacyLineBoxes): Deleted.
(WebCore::RenderInline::createInlineFlowBox): Deleted.
(WebCore::RenderInline::createAndAppendInlineFlowBox): Deleted.
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLineFromChangedChild):
* Source/WebCore/rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::createAndAppendInlineFlowBox):
(WebCore::RenderSVGInline::deleteLegacyLineBoxes):
(WebCore::RenderSVGInline::willBeDestroyed):
* Source/WebCore/rendering/svg/RenderSVGInline.h:
Canonical link: https://commits.webkit.org/320890@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
