Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 00e08007284d12603b41f85ccca61ceea6c1398b
https://github.com/WebKit/WebKit/commit/00e08007284d12603b41f85ccca61ceea6c1398b
Author: Alan Baradlay <[email protected]>
Date: 2026-09-11 (Fri, 11 Sep 2026)
Changed paths:
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
Log Message:
-----------
[cleanup] Compute inline box repaint rects through localRectsForRepaint like
every other renderer
https://bugs.webkit.org/show_bug.cgi?id=323755
<rdar://problem/187016759>
Reviewed by Antti Koivisto.
A renderer returns its repaint rect in its own coordinates from
localRectsForRepaint(), and
RenderObject maps it up to the repaint container through
computeVisibleRectsInContainer().
RenderInline did both, so the mapping was written twice, once by hand in
clippedOverflowRect() and
once in its own computeVisibleRectsInContainer(), and both copies had to be
kept in sync.
Implement localRectsForRepaint() instead, returning the lines visual overflow
rect inflated by the used outline size, and let the shared code do the mapping.
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::localRectsForRepaint):
(WebCore::RenderInline::clippedOverflowRect): Deleted.
(WebCore::RenderInline::rectsForRepaintingAfterLayout): Deleted.
* Source/WebCore/rendering/RenderInline.h:
Canonical link: https://commits.webkit.org/320923@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
