Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f45cdb1e659fdee5d8fee651626e707455521485
https://github.com/WebKit/WebKit/commit/f45cdb1e659fdee5d8fee651626e707455521485
Author: Michael Catanzaro <[email protected]>
Date: 2026-09-13 (Sun, 13 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/StdlibExtras.swift
M Source/bmalloc/libpas/src/libpas/pas_mte_config.c
M Source/cmake/WebKitCompilerFlags.cmake
M Source/cmake/WebKitSwiftFlags.cmake
M Tools/Scripts/webkitperl/FeatureList.pm
M Tools/TestWebKitAPI/Tests/WebCore/PushDatabase.cpp
Log Message:
-----------
REGRESSION(320261@main): [CMake][GTK][WPE] -Werror is not used even if
DEVELOPER_MODE_FATAL_WARNINGS is enabled
https://bugs.webkit.org/show_bug.cgi?id=323574
Reviewed by Adrian Taylor.
This commit removes the DEVELOPER_MODE_FATAL_WARNINGS CMake option.
Instead, build-webkit will set CMAKE_COMPILE_WARNING_AS_ERROR which
achieves the same result *without* breaking compiler feature probes.
This CMake setting tells CMake to use -Werror when building CMake
targets, but not for probes like check_cxx_source_compiles(). If the
user has set the value of CMAKE_COMPILE_WARNING_AS_ERROR then that
should be respected; if unset, it is automatically enabled if
DEVELOPER_MODE is enabled.
If you were previously using -DDEVELOPER_MODE_FATAL_WARNINGS=OFF, now
you must use -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF instead.
This change applies fatal warnings to Swift for the first time. We have
to fix one deprecated declarations warning, and also check the Swift
compiler version before using new warnings, because use of unknown
warnings produces a warning, which is now fatal.
This commit also fixes a few other trivial build warnings, since fatal
warnings have been inadvertently disabled on EWS since 320261@main.
* Source/WebKit/UIProcess/StdlibExtras.swift:
* Source/bmalloc/libpas/src/libpas/pas_mte_config.c:
* Source/cmake/WebKitCompilerFlags.cmake:
* Source/cmake/WebKitSwiftFlags.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:
* Tools/TestWebKitAPI/Tests/WebCore/PushDatabase.cpp:
(TestWebKitAPI::TEST(PushDatabase, ManyInFlightOps)):
Canonical link: https://commits.webkit.org/321007@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
