Branch: refs/heads/webkitglib/2.54
Home: https://github.com/WebKit/WebKit
Commit: 8f2745d6d7b879c504e5ad593ad05cdc0f2c6ef8
https://github.com/WebKit/WebKit/commit/8f2745d6d7b879c504e5ad593ad05cdc0f2c6ef8
Author: Andy Estes <[email protected]>
Date: 2026-09-14 (Mon, 14 Sep 2026)
Changed paths:
A
LayoutTests/media/media-source/worker/media-source-worker-logger-observer-crash-expected.txt
A
LayoutTests/media/media-source/worker/media-source-worker-logger-observer-crash.html
M LayoutTests/platform/glib/TestExpectations
M Source/WTF/wtf/Logger.cpp
M Source/WTF/wtf/Logger.h
M Source/WebCore/Modules/mediasource/MediaSource.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
Cherry-pick [email protected] (ed0a2c844690).
https://bugs.webkit.org/show_bug.cgi?id=318837
MediaSource should remove itself as a Logger observer on destruction
https://bugs.webkit.org/show_bug.cgi?id=318837
rdar://177356913
Reviewed by Eric Carlson.
Logger stores raw references to observers in Logger::observers(), so the
observer is responsible
for removing itself from Logger::observers() prior to destruction. Modified
MediaSource's
destructor do call Logger::removeObserver, and modified Logger::Observer's
destructor to
RELEASE_ASSERT that the observer has been removed.
Test:
media/media-source/worker/media-source-worker-logger-observer-crash.html
*
LayoutTests/media/media-source/worker/media-source-worker-logger-observer-crash-expected.txt:
Added.
*
LayoutTests/media/media-source/worker/media-source-worker-logger-observer-crash.html:
Added.
* Source/WTF/wtf/Logger.cpp:
(WTF::Logger::Observer::assertIsNotRegistered const):
* Source/WTF/wtf/Logger.h:
(WTF::Logger::Observer::~Observer):
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::~MediaSource):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::configureLoggingChannel):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Identifier: [email protected]
Canonical link: https://commits.webkit.org/317695.306@webkitglib/2.54
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
