Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d617718d6a00c1680703c368a29d405324cb4b82
https://github.com/WebKit/WebKit/commit/d617718d6a00c1680703c368a29d405324cb4b82
Author: Alan Baradlay <[email protected]>
Date: 2026-09-14 (Mon, 14 Sep 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
Log Message:
-----------
[cleanup] Move the geometry mapping code RenderBox and RenderInline share to
RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=323870
<rdar://problem/187110755>
Reviewed by Antti Koivisto.
pushMappingToContainer()
1, finds the container,
2, pushes the offset onto the geometry map and
3, returns where to continue,
and computeVisibleRectsUsingPaintOffset()
1, applies the in-flow position offset,
2, the layout state's paint offset and
3. its clip.
Neither needs to know whether the renderer is a box or an inline box, yet
RenderBox and RenderInline each have a copy.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeVisibleRectsUsingPaintOffset):
(WebCore::RenderBox::pushMappingToContainer): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pushMappingToContainer):
(WebCore::RenderBoxModelObject::computeVisibleRectsUsingPaintOffset):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::computeVisibleRectsUsingPaintOffset): Deleted.
(WebCore::RenderInline::pushMappingToContainer): Deleted.
* Source/WebCore/rendering/RenderInline.h:
Canonical link: https://commits.webkit.org/321091@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
