Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3ff034369d0db2dd47eb57dc932ab45547684f70
https://github.com/WebKit/WebKit/commit/3ff034369d0db2dd47eb57dc932ab45547684f70
Author: Chris Dumez <[email protected]>
Date: 2026-09-14 (Mon, 14 Sep 2026)
Changed paths:
M
Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp
M Source/WTF/wtf/Assertions.h
M Source/WTF/wtf/StdLibExtras.h
M Source/WTF/wtf/URLParser.cpp
M Source/WTF/wtf/cocoa/FileSystemCocoa.mm
M Source/WTF/wtf/glib/FilePathWatcher.cpp
M Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
M Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp
M Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/push-api/PushDatabase.cpp
M Source/WebCore/Modules/webdatabase/Database.cpp
M Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/dom/DocumentImmersive.cpp
M Source/WebCore/fileapi/FileCocoa.mm
M Source/WebCore/history/BackForwardCache.cpp
M Source/WebCore/html/HTMLAttachmentElement.cpp
M Source/WebCore/loader/ApplicationManifestLoader.cpp
M Source/WebCore/loader/ContentFilter.cpp
M Source/WebCore/loader/ResourceMonitor.cpp
M Source/WebCore/loader/ResourceMonitorChecker.cpp
M Source/WebCore/loader/ResourceMonitorThrottler.cpp
M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/loader/cache/MemoryCache.cpp
M Source/WebCore/loader/icon/IconLoader.cpp
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/MemoryRelease.cpp
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/PageSerializer.cpp
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebCore/platform/PODIntervalTree.h
M Source/WebCore/platform/PODRedBlackTree.h
M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.mm
M Source/WebCore/platform/cocoa/FileMonitorCocoa.mm
M Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm
M Source/WebCore/platform/graphics/BitmapImageSource.cpp
M Source/WebCore/platform/graphics/ImageFrameAnimator.cpp
M Source/WebCore/platform/graphics/cg/ImageUtilitiesCG.cpp
M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
M Source/WebCore/platform/graphics/egl/GLContext.cpp
M Source/WebCore/platform/graphics/vulkan/VulkanTypes.cpp
M Source/WebCore/platform/graphics/vulkan/VulkanUtilities.cpp
M
Source/WebCore/platform/mediastream/cocoa/CoreAudioCaptureDeviceManager.cpp
M Source/WebCore/platform/mediastream/cocoa/CoreAudioCaptureSource.cpp
M Source/WebCore/platform/mediastream/cocoa/CoreAudioCaptureUnit.cpp
M
Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm
M Source/WebCore/platform/mock/MediaPlaybackTargetPickerMock.cpp
M Source/WebCore/platform/network/BlobRegistryImpl.cpp
M Source/WebCore/platform/network/MIMEHeader.cpp
M Source/WebCore/platform/network/curl/CookieJarDB.cpp
M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
M Source/WebCore/platform/sql/SQLiteDatabase.cpp
M Source/WebCore/platform/win/SearchPopupMenuDB.cpp
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebCore/storage/StorageUtilities.cpp
M Source/WebCore/testing/Internals.mm
M Source/WebCore/workers/WorkerRunLoop.cpp
M Source/WebCore/workers/service/SWClientConnection.cpp
M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
M Source/WebCore/workers/service/context/SWContextManager.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
M Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp
M Source/WebCore/workers/service/server/SWScriptStorage.cpp
M Source/WebCore/workers/service/server/SWServer.cpp
M Source/WebCore/workers/service/server/SWServerJobQueue.cpp
M Source/WebCore/workers/shared/SharedWorker.cpp
M Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp
M Source/WebDriver/Logging.h
M Source/WebDriver/Session.cpp
M Source/WebDriver/SessionHost.cpp
M Source/WebDriver/WebDriverService.cpp
M Source/WebDriver/WebSocketServer.cpp
M Source/WebDriver/glib/SessionHostGlib.cpp
M Source/WebDriver/soup/WebSocketServerSoup.cpp
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/NetworkProcess/BackgroundFetchLoad.cpp
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
M Source/WebKit/NetworkProcess/DatabaseUtilities.cpp
M Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
M
Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp
M
Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp
M Source/WebKit/Platform/IPC/FormDataReference.cpp
M Source/WebKit/Platform/IPC/HandleMessage.h
M Source/WebKit/Platform/Logging.h
M Source/WebKit/Platform/cocoa/AssertionCapability.mm
M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
M Source/WebKit/Shared/Extensions/WebExtensionLocalization.cpp
M
Source/WebKit/Shared/Extensions/WebExtensionRegisteredScriptsSQLiteStore.cpp
M
Source/WebKit/Shared/Extensions/WebExtensionRegisteredScriptsSQLiteStoreCocoa.mm
M Source/WebKit/Shared/Extensions/WebExtensionSQLiteDatabase.cpp
M Source/WebKit/Shared/Extensions/WebExtensionSQLiteStore.cpp
M Source/WebKit/Shared/WebPreferencesStore.cpp
M Source/WebKit/Shared/cf/CoreIPCSecTrust.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView+TextExtraction.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/glib/IconDatabase.cpp
M Source/WebKit/UIProcess/Automation/WebDriverBidiProcessor.cpp
M Source/WebKit/UIProcess/Cocoa/ExtensionCapabilityGranter.mm
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm
M
Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp
M
Source/WebKit/UIProcess/Extensions/API/WebExtensionContextAPIDeclarativeNetRequest.cpp
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDeclarativeNetRequestSQLiteStoreCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp
M
Source/WebKit/UIProcess/Extensions/WebExtensionDeclarativeNetRequestSQLiteStore.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.cpp
M Source/WebKit/UIProcess/Extensions/glib/WebExtensionContextGLib.cpp
M Source/WebKit/UIProcess/Extensions/glib/WebExtensionGLib.cpp
M Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorClient.cpp
M
Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
M Source/WebKit/UIProcess/PerActivityStateCPUUsageSampler.cpp
M Source/WebKit/UIProcess/SecurityFlagsController.cpp
M Source/WebKit/UIProcess/UserMediaProcessManager.cpp
M Source/WebKit/UIProcess/ViewGestureController.cpp
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
M Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp
M Source/WebKit/UIProcess/WebBackForwardCache.cpp
M Source/WebKit/UIProcess/WebBackForwardCacheEntry.cpp
M Source/WebKit/UIProcess/WebBackForwardList.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessCache.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/_WKWebViewPrintFormatter.mm
M Source/WebKit/UIProcess/ios/LayerHostingVisibilityPropagator.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.cpp
M Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.cpp
M
Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm
M Source/WebKit/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
M Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Storage/WebSharedWorkerObjectConnection.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/webpushd/PushClientConnection.mm
M Source/WebKit/webpushd/PushService.mm
M Source/WebKit/webpushd/WebPushDaemon.mm
M Source/WebKit/webpushd/WebPushDaemonMain.mm
M Source/WebKitLegacy/Storage/StorageAreaSync.cpp
M Source/WebKitLegacy/Storage/StorageSyncManager.cpp
M Source/WebKitLegacy/WebCoreSupport/WebSocketChannel.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
Log Message:
-----------
Reduce use of CString::legacyCStringPointer() in logging macros
https://bugs.webkit.org/show_bug.cgi?id=324142
Reviewed by Mike Wyrzykowski.
This brings the number of legacyCStringPointer() call sites down from 1748 to
1163. The previous pass (320917@main) left os_log-based RELEASE_LOG as
irreducible without new API; this adds that API.
Add WTF::logPrintfType() and LOG_PRINTF_TYPE() next to safePrintfType(), and
apply them to LOG, LOG_ERROR, LOG_VERBOSE, LOG_WITH_LEVEL and the RELEASE_LOG
family in all four platform branches, so a call site can pass a CString and let
the macro reach for the pointer. logPrintfType() differs from safePrintfType()
in passing a raw pointer through rather than rejecting char*: a log call site
often has a const char* from a C or Objective-C interface that it cannot
convert without a copy, and pointers also cover the objects os_log's %@ takes.
Format-string checking is unaffected; a bare String is still rejected.
Assertions.h is included from C and Objective-C files, where the C++ helper
does not exist, so the conversion goes through WTF_LOG_PRINTF_ARGS().
WebKit's and WebDriver's OPTIONAL_ARGS now convert their arguments, matching
WebCore's. Without that, the *_FORWARDABLE macros glue the arguments onto the
format string as a single macro parameter and they never reach the conversion.
* Source/*:
Canonical link: https://commits.webkit.org/321137@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
