Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: da6f3a668758b8997baa758a6671e7d560d3caf3
https://github.com/WebKit/WebKit/commit/da6f3a668758b8997baa758a6671e7d560d3caf3
Author: Tim Nguyen <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
A
LayoutTests/http/tests/site-isolation/checkbox-window-inactive-cross-origin-iframe-expected.html
A
LayoutTests/http/tests/site-isolation/checkbox-window-inactive-cross-origin-iframe.html
A LayoutTests/http/tests/site-isolation/resources/checkbox-iframe.html
M Source/WebCore/page/FocusController.cpp
Log Message:
-----------
[Site Isolation] <input type="checkbox"> is not greyed out when window
becomes inactive
https://bugs.webkit.org/show_bug.cgi?id=324204
rdar://185648417
Reviewed by Ryosuke Niwa.
<input type="checkbox"> and other controls in a cross-origin iframe were
not repainted when the containing window's active state changed, because
FocusController::setActiveInternal() bailed out early when
Page::localMainFrame()
returned null. Under Site Isolation, the WebProcess hosting a cross-origin
iframe has a Page whose main frame is a RemoteFrame placeholder, so the
"fake paint" pass that invalidates control tints was never triggered there,
even though the process had already received the correct WindowIsActive
state via IPC.
Use Page::localMainOrRootFrame() instead, which falls back to the process's
local root frame when the main frame is remote, matching the fallback
Page::updateControlTints() already uses for the same reason.
Test:
http/tests/site-isolation/checkbox-window-inactive-cross-origin-iframe.html
*
LayoutTests/http/tests/site-isolation/checkbox-window-inactive-cross-origin-iframe-expected.html:
Added.
*
LayoutTests/http/tests/site-isolation/checkbox-window-inactive-cross-origin-iframe.html:
Added.
* LayoutTests/http/tests/site-isolation/resources/checkbox-iframe.html: Added.
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setActiveInternal):
Canonical link: https://commits.webkit.org/321144@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
