Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b903f45d00b8a3969368386b833f5997cc5b4d5e
https://github.com/WebKit/WebKit/commit/b903f45d00b8a3969368386b833f5997cc5b4d5e
Author: Simon Fraser <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
M Tools/Scripts/webkitpy/port/apple.py
M Tools/Scripts/webkitpy/port/base.py
Log Message:
-----------
`run-webkit-tests --layout-tests-directory` produces empty -diff.html files
https://bugs.webkit.org/show_bug.cgi?id=324203
rdar://187417149
Reviewed by Abrar Rahman Protyasha.
When providing a custom layout tests root directory via
`--layout-tests-directory`,
the image comparison files are blank. Fix by TestResultWriter and
`_copy_results_html_file`
use an explitic path relative to `self.webkit_base()` instead of one affected by
`--layout-tests-directory`.
Also fix `baseline_search_path` and `_apple_baseline_path` so that
TestExpectations
are searched for in the provided root.
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._copy_results_html_file):
* Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):
* Tools/Scripts/webkitpy/port/base.py:
(Port.harness_resources_dir):
(Port.baseline_search_path):
* Tools/Scripts/webkitpy/port/apple.py:
(ApplePort._apple_baseline_path):
Canonical link: https://commits.webkit.org/321173@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
