Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56cb0a4b760798f89c7d33cb08656fd0b2555e6e
https://github.com/WebKit/WebKit/commit/56cb0a4b760798f89c7d33cb08656fd0b2555e6e
Author: Marta Darbinyan <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] webkitperl-tests failures silently reported as SUCCESS
https://bugs.webkit.org/show_bug.cgi?id=323885
rdar://187125906
Reviewed by Aakash Jain.
The step was set up to defer flunking to a retry that never actually ran —
shell.ShellCommand has no evaluateCommand for the override to hook into,
so the retry step was never scheduled and failures rolled up as SUCCESS.
Run test-webkitperl once and flunk on failure. Keep it locked in with a
unit test — this has regressed silently before.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitPerlTests): flunk on failure; drop evaluateCommand override
and ReRunWebKitPerlTests.
* Tools/CISupport/ews-build/events.py: Drop re-run-webkitperl-tests.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitPerlTests.test_flunks_build_on_failure): Added.
Canonical link: https://commits.webkit.org/321190@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
