Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8d2d76d92ac6cb3027aa0e8d3f7ee19c3fc55a70
https://github.com/WebKit/WebKit/commit/8d2d76d92ac6cb3027aa0e8d3f7ee19c3fc55a70
Author: Alan Baradlay <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
Log Message:
-----------
[cleanup] Move computeVisibleRectsInContainer() up to RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=324101
<rdar://problem/187318089>
Reviewed by Antti Koivisto.
RenderBox and RenderInline walked to the container the same way, so
RenderBoxModelObject does it now and asks for a box only where one is needed:
reflectedRect(), flipForWritingMode(), locationOffset() and the layer's
transform.
An inline box keeps VisibleRectContext::Option::ApplyCompositedContainerScrolls
on the container clip. The paint offset cache's PositionType::Fixed check does
not reach it since an out-of-flow position blockifies display.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeVisibleRectsInContainer const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeVisibleRectsInContainer const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::computeVisibleRectsInContainer const): Deleted.
* Source/WebCore/rendering/RenderInline.h:
Canonical link: https://commits.webkit.org/321208@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications