Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7b08c643e057183f892345bff2dbf66dd8483070
https://github.com/WebKit/WebKit/commit/7b08c643e057183f892345bff2dbf66dd8483070
Author: Chris Dumez <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Source/WebCore/Modules/webaudio/AudioListener.h
M Source/WebCore/bindings/js/JSPluginElementFunctions.cpp
M Source/WebCore/bindings/js/JSPluginElementFunctions.h
M Source/WebCore/bridge/objc/WebScriptObject.mm
M Source/WebCore/css/values/CSSValueAggregates.h
M Source/WebCore/testing/Internals.cpp
Log Message:
-----------
Address David's post-landing review feedback about 321136@main
https://bugs.webkit.org/show_bug.cgi?id=324225
Reviewed by David Kilzer.
* Source/WebCore/Modules/webaudio/AudioListener.h:
* Source/WebCore/bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginInstance):
This is a partial revert of 321136@main. We only needed to return a
smart pointer here because we stored `pluginElement->bindingsInstance()`
in a local variable and static analysis was requiring us to store in in
a RefPtr. However, we can factor the code differently to avoid the local
variable completely and keep the function return type as it was before
321136@main, thus minimizing changes.
* Source/WebCore/bindings/js/JSPluginElementFunctions.h:
* Source/WebCore/bridge/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
Claude over-reached in 321136@main and had converted a line that had no
safer cpp warning so I am reverting the change. getObject() is treated
as trivial by static analysis and thus not requiring a smart pointer here.
* Source/WebCore/css/values/CSSValueAggregates.h:
(WebCore::CommaSeparatedEnumSet::map):
(WebCore::SpaceSeparatedOrderedHashSet::map):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::queueMicroTask):
(WebCore::Internals::requestTextRecognition):
Canonical link: https://commits.webkit.org/321216@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
