Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f47af0c2b9a4c43e0f6aea50081f34cf6ba04c0
https://github.com/WebKit/WebKit/commit/5f47af0c2b9a4c43e0f6aea50081f34cf6ba04c0
Author: Phinehas Fuachie <[email protected]>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
Log Message:
-----------
-[WKFullScreenWindowController prefersSceneDimming] falls back to YES when
there is no best video, which is every fullscreen entry
https://bugs.webkit.org/show_bug.cgi?id=324284
rdar://184260580
Reviewed by Andy Estes.
bestVideoForElementFullscreen() needs the model's isChildOfElementFullscreen
flag, and that only
arrives over IPC after _enterFullScreen: has already seeded the lightspill flag
from this property.
So we always took the fallback and turned dimming on no matter what the user
picked, then never
revisited it. With no video in the element there is no best video at all, so it
just stayed on.
All that lookup gave us was a cached copy of the WebKitPrefersFullScreenDimming
default anyway, so
read the default and drop the member. toggleSceneDimming writes it
unconditionally now, since we
were throwing the write away whenever there was no best video.
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::PlaybackSessionModelContext):
(WebKit::PlaybackSessionModelContext::persistedPrefersAutoDimming):
(WebKit::PlaybackSessionModelContext::setPersistedPrefersAutoDimming):
(WebKit::PlaybackSessionModelContext::setPrefersAutoDimming):
(WebKit::PlaybackSessionManagerProxy::prefersAutoDimming const): Deleted.
(WebKit::PlaybackSessionManagerProxy::setPrefersAutoDimming): Deleted.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController didExitVideoFullscreen]):
(-[WKFullScreenWindowController prefersSceneDimming]):
(-[WKFullScreenWindowController toggleSceneDimming]):
Canonical link: https://commits.webkit.org/321218@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
