Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 12a60d1a396bf4f9b850c728493125edda113597
https://github.com/WebKit/WebKit/commit/12a60d1a396bf4f9b850c728493125edda113597
Author: Tim Nguyen <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
A Source/WebCore/css/CSSSymbolsFunctionValue.cpp
A Source/WebCore/css/CSSSymbolsFunctionValue.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp
M Source/WebCore/css/values/counter-styles/CSSCounterStyle.h
Log Message:
-----------
[CSS symbols() function] Parsing & value representation
https://bugs.webkit.org/show_bug.cgi?id=324481
rdar://187720851
Reviewed by Sam Weinig.
https://drafts.csswg.org/css-counter-styles/#symbols-function
symbols() = symbols( <symbols-type>? [ <string> | <image> ]+ )
<symbols-type> = cyclic | numeric | alphabetic | symbolic | fixed
<image> is currently not supported in the list of symbols, but this matches
Chrome & Firefox.
Don't add the symbols function to the CounterStyle variant to avoid making this
PR too large.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isSymbolsFunctionValue const):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp:
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedSymbolsType):
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedSymbolsFunction):
(WebCore::CSSPropertyParserHelpers::consumeCounterStyle):
* Source/WebCore/css/values/counter-styles/CSSCounterStyle.h:
(WebCore::CSS::get):
* Source/WebCore/css/CSSSymbolsFunctionValue.cpp: Copied from
Source/WebCore/css/values/counter-styles/CSSCounterStyle.h.
(WebCore::CSSSymbolsFunctionValue::create):
(WebCore::CSSSymbolsFunctionValue::CSSSymbolsFunctionValue):
(WebCore::CSSSymbolsFunctionValue::customCSSText const):
(WebCore::CSSSymbolsFunctionValue::equals const):
(WebCore::CSSSymbolsFunctionValue::customVisitChildren const):
* Source/WebCore/css/CSSSymbolsFunctionValue.h: Copied from
Source/WebCore/css/values/counter-styles/CSSCounterStyle.h.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt:
Canonical link: https://commits.webkit.org/321400@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
