Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: af71d8f847f70cae1010ec7312e4611b5bd55bf1
https://github.com/WebKit/WebKit/commit/af71d8f847f70cae1010ec7312e4611b5bd55bf1
Author: Alex Christensen <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/Cocoa/RevealItem.h
M Source/WebKit/Shared/Cocoa/RevealItem.serialization.in
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
Make context menus appear when selected text is in a site isolated iframe
https://bugs.webkit.org/show_bug.cgi?id=324487
rdar://168714875
Reviewed by Ryosuke Niwa.
Messages::WebPage::PrepareSelectionForContextMenuWithLocationInView was being
sent to the wrong process,
and the receiver only worked if the main frame was a LocalFrame. This fixes
both issues.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView
_internalSelectTextForContextMenuWithLocationInView:completionHandler:]):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::prepareSelectionForContextMenuWithLocationInView):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::remoteUserInputEventDataForSelectionGesture):
(WebKit::remoteUserInputEventDataForSelectionGesture): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::prepareSelectionForContextMenuWithLocationInView):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation, EditMenuSelectsWordInCrossOriginIframe)):
* Source/WebKit/Scripts/webkit/messages.py:
(conditions_for_header):
(headers_for_type):
* Source/WebKit/Shared/Cocoa/RevealItem.h:
* Source/WebKit/Shared/Cocoa/RevealItem.serialization.in:
Canonical link: https://commits.webkit.org/321393@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
