Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9ea68824aec3c6b238d443b4573b01866ff16291
https://github.com/WebKit/WebKit/commit/9ea68824aec3c6b238d443b4573b01866ff16291
Author: Alex Christensen <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
Use sendWithAsyncReply for Messages::WebPage::RequestPositionInformation
https://bugs.webkit.org/show_bug.cgi?id=324590
Reviewed by Wenson Hsieh and Megan Gardner.
Right now it's sent to the legacy main frame process.
For site isolation, in order to fix bugs like rdar://185926851
we need to send it to a different process sometimes. All the
solutions to keep track of this without using sendWithAsyncReply
are pretty messy, so this is a step towards cleaner solutions.
We want to keep track of the AsyncReplyID to wait for, then wait
for that.
No change in behavior.
* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::waitForAsyncReplyAndDispatchImmediately):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::requestPositionInformation):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView ensurePositionInformationIsUpToDate:]):
(-[WKContentView requestAsynchronousPositionInformationUpdate:]):
(-[WKContentView _hasValidOutstandingPositionInformationRequest:]):
(-[WKContentView _positionInformationDidChange:]):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::requestPositionInformation):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/321430@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
