Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1d3b6139b33e751e4681cd50020ac2d5b0c199f1
https://github.com/WebKit/WebKit/commit/1d3b6139b33e751e4681cd50020ac2d5b0c199f1
Author: Alex Christensen <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
Log Message:
-----------
Use WKKeyedCoder when decoding a WebFilterEvaluator from IPC
https://bugs.webkit.org/show_bug.cgi?id=324593
rdar://187385256
Reviewed by Ryosuke Niwa.
Before this change, CoreIPCWebFilterEvaluator::toID had this line in the
generated code:
RELEASE_ASSERT([PAL::getWebFilterEvaluatorClassSingleton()
instancesRespondToSelector:@selector(_initWithWebKitPropertyListData:)]);
That assertion failed 100% of the time, and code inspection verified the lack
of selector.
This should fix the crash for our users that hit it.
I added a unit test that hits the crash on iOS 26 before but not after the fix.
Test: Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(operator==):
(TEST(IPCSerialization, WebFilterEvaluator)):
Canonical link: https://commits.webkit.org/321438@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
