Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b925d548f59d6438433a0b660d3a01aeaed6fd65
https://github.com/WebKit/WebKit/commit/b925d548f59d6438433a0b660d3a01aeaed6fd65
Author: Fady Farag <[email protected]>
Date: 2026-09-19 (Sat, 19 Sep 2026)
Changed paths:
M Tools/CISupport/Shared/steps.py
M Tools/CISupport/Shared/steps_unittest.py
M Tools/CISupport/build-webkit-org/factories.py
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[Safer-CPP] Remove steps to checkout LLVM project
https://bugs.webkit.org/show_bug.cgi?id=322909
rdar://186165200
Reviewed by Ryosuke Niwa and Sam Sneddon.
On the Safer C++ bots, the `rniwa/llvm-project` checkout at
`safer-cpp-llvm-version`
is never built. It is only used for `clang/tools/scan-build/bin/scan-build`,
which
runs after the static analysis just to generate the results `index.html` page.
The
actual static analysis is done by the `swift-webkit` toolchain's Clang, and the
swift checkout used to build that toolchain already contains the same
`scan-build`
script. This points `--scan-build-path` there and removes the unnecessary steps.
* Tools/CISupport/Shared/steps.py:
(InstallNinja.getResultSummary):
(getResultSummary):
(GetLLVMVersion): Deleted.
(GetLLVMVersion.__init__): Deleted.
(GetLLVMVersion.run): Deleted.
(GetLLVMVersion.getResultSummary): Deleted.
(CheckOutLLVMProject): Deleted.
(CheckOutLLVMProject.__init__): Deleted.
(CheckOutLLVMProject.run_vc): Deleted.
(CheckOutLLVMProject.parseGotRevision): Deleted.
(CheckOutLLVMProject.doStepIf): Deleted.
(CheckOutLLVMProject.getResultSummary): Deleted.
(UpdateClang): Deleted.
(UpdateClang.__init__): Deleted.
(UpdateClang.run): Deleted.
(UpdateClang.doStepIf): Deleted.
(UpdateClang.getResultSummary): Deleted.
(PrintClangVersion): Deleted.
(PrintClangVersion.__init__): Deleted.
(PrintClangVersion.run): Deleted.
(PrintClangVersion.getResultSummary): Deleted.
(PrintClangVersionAfterUpdate): Deleted.
(PrintClangVersionAfterUpdate.run): Deleted.
(PrintClangVersionAfterUpdate.getResultSummary): Deleted.
* Tools/CISupport/Shared/steps_unittest.py:
(BuildStepMixinAdditions.run_step):
(TestPrintClangVersion): Deleted.
(TestPrintClangVersion.setUp): Deleted.
(TestPrintClangVersion.tearDown): Deleted.
(TestPrintClangVersion.configureStep): Deleted.
(TestPrintClangVersion.test_success): Deleted.
(TestPrintClangVersion.test_failure): Deleted.
(TestGetLLVMVersion): Deleted.
(TestGetLLVMVersion.setUp): Deleted.
(TestGetLLVMVersion.tearDown): Deleted.
(TestGetLLVMVersion.configureStep): Deleted.
(TestGetLLVMVersion.test_success): Deleted.
(TestCheckoutLLVMProject): Deleted.
(TestCheckoutLLVMProject.setUp): Deleted.
(TestCheckoutLLVMProject.tearDown): Deleted.
(TestCheckoutLLVMProject.configureStep): Deleted.
(TestCheckoutLLVMProject.test_skipped): Deleted.
(TestUpdateClang): Deleted.
(TestUpdateClang.setUp): Deleted.
(TestUpdateClang.tearDown): Deleted.
(TestUpdateClang.configureStep): Deleted.
(TestUpdateClang.test_success): Deleted.
(TestUpdateClang.test_skipped): Deleted.
(TestUpdateClang.test_use_previous_build): Deleted.
* Tools/CISupport/build-webkit-org/factories.py:
(SaferCPPStaticAnalyzerFactory.__init__):
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/steps.py:
(ScanBuild.run):
(FindUnexpectedStaticAnalyzerResults.run):
(SetPermissions.__init__):
(PrintClangVersion): Deleted.
(PrintClangVersion.run): Deleted.
(PrintClangVersion.getResultSummary): Deleted.
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/CISupport/ews-build/factories.py:
(SaferCPPStaticAnalyzerFactory.__init__):
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(ScanBuild.run):
(FindUnexpectedStaticAnalyzerResultsWithoutChange.run):
(GenerateSaferCPPResultsIndex.run):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/321447@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
