Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ffa85990a6854db5651440f20baf11c90290a22d
https://github.com/WebKit/WebKit/commit/ffa85990a6854db5651440f20baf11c90290a22d
Author: Anne van Kesteren <[email protected]>
Date: 2026-09-21 (Mon, 21 Sep 2026)
Changed paths:
A
LayoutTests/inspector/canvas/recording-webgl-preserves-arguments-expected.txt
A LayoutTests/inspector/canvas/recording-webgl-preserves-arguments.html
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.idl
M Source/WebCore/inspector/InspectorCanvasArguments.h
Log Message:
-----------
Replace WebGL's BufferDataSource with BufferSource
https://bugs.webkit.org/show_bug.cgi?id=324654
Reviewed by Dan Glastonbury.
Thanks to 321465@main WebGL can use BufferSource directly.
A nullable BufferSource reaches the canvas call tracer as std::optional rather
than the RefPtr the Typed Arrays use, which exposed a bug in
InspectorCanvasArgumentProcessor. It took its argument by mutable reference and
consumed it with releaseNonNull(). This bug was confirmed by the added test and
is now fixed.
Test: inspector/canvas/recording-webgl-preserves-arguments.html
Canonical link: https://commits.webkit.org/321491@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
