Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 877918e1be8614c5dcd0f27f438f393ab85ef1d5
https://github.com/WebKit/WebKit/commit/877918e1be8614c5dcd0f27f438f393ab85ef1d5
Author: Ahmad Saleem <[email protected]>
Date: 2026-09-21 (Mon, 21 Sep 2026)
Changed paths:
M Source/WebCore/dom/Element.cpp
Log Message:
-----------
Element::setScrollLeft/setScrollTop re-check a guaranteed-non-null renderer
and call layer() twice
https://bugs.webkit.org/show_bug.cgi?id=324666
rdar://187925755
Reviewed by Ryosuke Niwa.
Inside `if (CheckedPtr renderer = renderBox())`, both setScrollLeft() and
setScrollTop() computed the scrollable area with:
if (auto* scrollableArea = renderer && renderer->layer() ?
renderer->layer()->scrollableArea() : nullptr)
The `renderer &&` guard is dead — renderer is the branch condition and cannot
be null here — and layer() is evaluated twice. Replace with a single CheckedPtr
guard over layer(). No behavior change.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
Canonical link: https://commits.webkit.org/321527@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
