Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad58f50e68ffa3faad58f7a325742dc7f2b69028
https://github.com/WebKit/WebKit/commit/ad58f50e68ffa3faad58f7a325742dc7f2b69028
Author: Sihui Liu <[email protected]>
Date: 2026-09-21 (Mon, 21 Sep 2026)
Changed paths:
M Source/WebKit/Shared/WebsitePoliciesData.h
M Source/WebKit/Shared/WebsitePoliciesData.serialization.in
M Source/WebKit/UIProcess/API/APIWebsitePolicies.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
Rename _allowSharedProcess to _prefersIsolatedProcess
https://bugs.webkit.org/show_bug.cgi?id=324636
rdar://187886280
Reviewed by Ryosuke Niwa and Per Arne Vollan.
_allowSharedProcess was named as if the client could veto placing a site in the
shared process, but the process decision
is made per (browsing context group, site) and is never revisited. Only the
first navigation to a site in a group
consults the policy, so setting _allowSharedProcess = NO on a later navigation
to a site that already joined the shared
process has no effect. The scope of the API (per navigation) is finer than the
scope of the decision (per browsing
context group), which makes any API of this shape order dependent. In practice
it expresses a preference, not a
guarantee.
Rename it to _prefersIsolatedProcess so the name matches what it does. The
polarity is inverted along with the name.
This does not change the per browsing context group stickiness described above;
it only stops the name from promising
something the API cannot deliver.
* Source/WebKit/Shared/WebsitePoliciesData.h:
* Source/WebKit/Shared/WebsitePoliciesData.serialization.in:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _prefersIsolatedProcess]):
(-[WKWebpagePreferences _setPrefersIsolatedProcess:]):
(-[WKWebpagePreferences _allowSharedProcess]): Deleted.
(-[WKWebpagePreferences _setAllowSharedProcess:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::sharedProcessForSite):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, UnresponsiveProcessMousedown)):
(TestWebKitAPI::(SiteIsolation, SharedProcessWithWebsitePolicies)):
Canonical link: https://commits.webkit.org/321530@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
