Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e8080f8501905943dbba34903ecdc169da7696de
https://github.com/WebKit/WebKit/commit/e8080f8501905943dbba34903ecdc169da7696de
Author: Sihui Liu <[email protected]>
Date: 2026-09-21 (Mon, 21 Sep 2026)
Changed paths:
M Source/WebCore/storage/StorageArea.h
M Source/WebKitLegacy/Storage/StorageSyncManager.h
Log Message:
-----------
REGRESSION(321462@main): ASSERTION FAILED: threadLikeAssertion.isCurrent()
under StorageAreaSync::openDatabase()
https://bugs.webkit.org/show_bug.cgi?id=324738
rdar://188017922
Reviewed by Ryosuke Niwa.
321462@main turned bare derefs in StorageAreaSync::openDatabase(),
performImport() and deleteEmptyDatabase() into
protect() calls. Those three run on the StorageThread, so they now ref/deref
StorageSyncManager and StorageArea — both
plain RefCounted, owned by the main thread — and trip RefCountDebugger's
threading check. Make both
ThreadSafeRefCounted with DestructionThread::Main, matching StorageAreaSync,
which is already declared that way.
* Source/WebCore/storage/StorageArea.h:
* Source/WebKitLegacy/Storage/StorageSyncManager.h:
Canonical link: https://commits.webkit.org/321562@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
