Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6f39f11c5e61b0b7cc3d3521ee1f301691951a7d
https://github.com/WebKit/WebKit/commit/6f39f11c5e61b0b7cc3d3521ee1f301691951a7d
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-09-21 (Mon, 21 Sep 2026)
Changed paths:
M Source/cmake/WebKitCommon.cmake
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitperl/webkitdirs_unittest/recordBuildSettings.pl
Log Message:
-----------
[cmake] that null builds aren't truly null builds anymore
https://bugs.webkit.org/show_bug.cgi?id=324648
rdar://187893054
Reviewed by Elliott Williams.
Following 321225@main, the RecordBuildSettings target had no output, so every
cmake build ran set-webkit-configuration and no build was ever null.
The build now records the settings through a stamp that depends on the base
product directory, whose time is the time a setting changed: creating or
deleting a setting file dates it
already, and set-webkit-configuration and
build-webkit date it when they rewrite one. A stamp newer than the directory
means the settings recorded are still those of this tree and the build has
nothing to do.
* Source/cmake/WebKitCommon.cmake:
* Tools/Scripts/webkitdirs.pm:
(writeFileIfChanged): Return whether the file was written.
(touchBaseProductDir): Added.
(writeBuildSetting): Date the base product directory when a setting changed.
(recordBuildSystemXcodeConfiguration): Ditto.
* Tools/Scripts/webkitperl/webkitdirs_unittest/recordBuildSettings.pl:
* Source/cmake/WebKitCommon.cmake:
* Tools/Scripts/webkitdirs.pm:
(writeFileIfChanged):
(touchBaseProductDir):
(writeBuildSetting):
(recordBuildSystemXcodeConfiguration):
* Tools/Scripts/webkitperl/webkitdirs_unittest/recordBuildSettings.pl:
Canonical link:
https://flagged.apple.com:443/proxy?t2=Do3f1H0PN7&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzIxNTY5QG1haW4=&emid=aba39072-1e0d-453b-adc7-528f270bf584&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
