Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7cf597aff9e753b181b769a0bd793ab8f9df4274
https://github.com/WebKit/WebKit/commit/7cf597aff9e753b181b769a0bd793ab8f9df4274
Author: Dominic Mazzoni <[email protected]>
Date: 2026-09-22 (Tue, 22 Sep 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/mac/replace-range-in-design-mode-document-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/replace-range-in-design-mode-document.html
A
LayoutTests/accessibility/mac/replace-range-in-design-mode-document-expected.txt
A LayoutTests/accessibility/mac/replace-range-in-design-mode-document.html
M Source/WebCore/accessibility/AccessibilityObject.cpp
Log Message:
-----------
AX: AXReplaceRangeWithText inserts at index 0 in a design-mode document
https://bugs.webkit.org/show_bug.cgi?id=324775
rdar://188021245
Reviewed by Tyler Wilcock.
320013@main (AX: AXReplaceRangeWithText inserts text at the wrong index) fixed a
genuine bug, but unfortunately regressed documents with designMode, such as the
Mac Mail compose window.
In particular that change moved replaceTextInRange off
rangeForCharacterRange and onto visiblePositionForIndex, which fixed
the index it resolves at a block boundary. Alongside that it added a
clamp of the requested range against getLengthForTextRange(), and that
clamp is wrong for an editing host that is not a text control.
Tests:
accessibility/isolated-tree/mac/replace-range-in-design-mode-document.html
accessibility/mac/replace-range-in-design-mode-document.html
*
LayoutTests/accessibility/isolated-tree/mac/replace-range-in-design-mode-document-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/mac/replace-range-in-design-mode-document.html:
Added.
*
LayoutTests/accessibility/mac/replace-range-in-design-mode-document-expected.txt:
Added.
* LayoutTests/accessibility/mac/replace-range-in-design-mode-document.html:
Added.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::replaceTextInRange):
Canonical link: https://commits.webkit.org/321610@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
