Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d78c848600c259024e6bbbf02ec9e697f03127f
https://github.com/WebKit/WebKit/commit/6d78c848600c259024e6bbbf02ec9e697f03127f
Author: Tim Nguyen <[email protected]>
Date: 2026-09-24 (Thu, 24 Sep 2026)
Changed paths:
M Source/WebCore/editing/AlternativeTextController.cpp
M Source/WebCore/editing/AlternativeTextController.h
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h
M Source/WebKit/WebProcess/WebCoreSupport/cocoa/WebAlternativeTextClient.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Spellcheck panel is positioned incorrectly in scrolled
cross-origin iframe
https://bugs.webkit.org/show_bug.cgi?id=325002
rdar://188209015
Reviewed by Ryosuke Niwa.
Use contentsToMainFrameView instead of contentsToRootView, and remove the usage
of convertRectToMainFrameCoordinates.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebCore/editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::show):
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::rootViewRectForRange const):
(WebCore::AlternativeTextController::mainFrameViewRectForRange const):
* Source/WebCore/editing/AlternativeTextController.h:
* Source/WebCore/page/AlternativeTextClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showCorrectionPanel):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/cocoa/WebAlternativeTextClient.cpp:
(WebKit::WebAlternativeTextClient::showCorrectionAlternative):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation,
ValidationMessageAnchorInScrolledCrossOriginIframeWithScrolledMainFrame)):
(TestWebKitAPI::swizzledShowCorrectionIndicatorCapturingAnchorRect):
(TestWebKitAPI::triggerCorrectionPanelAndCaptureAnchorRect):
(TestWebKitAPI::checkCorrectionPanelAnchorInCrossOriginIframe):
(TestWebKitAPI::TEST(SiteIsolation, CorrectionPanelAnchorInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
CorrectionPanelAnchorInCrossOriginIframeWithScrolledMainFrame)):
(TestWebKitAPI::TEST(SiteIsolation,
CorrectionPanelAnchorInScrolledCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
CorrectionPanelAnchorInScrolledCrossOriginIframeWithScrolledMainFrame)):
* Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.mm:
(WebAlternativeTextClient::showCorrectionAlternative):
Canonical link: https://commits.webkit.org/321807@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
