Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4d19ac74260ea32ba7e31d2560f0ac94fa28503f
https://github.com/WebKit/WebKit/commit/4d19ac74260ea32ba7e31d2560f0ac94fa28503f
Author: Charlie Wolfe <[email protected]>
Date: 2026-09-24 (Thu, 24 Sep 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/compositing/2d.composite.operation.darker-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/compositing/2d.composite.operation.darker-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/compositing/2d.composite.operation.darker.worker-expected.txt
M Source/WebCore/platform/graphics/GraphicsTypes.cpp
Log Message:
-----------
Canvas globalCompositeOperation should not accept the legacy "darker" operator
https://bugs.webkit.org/show_bug.cgi?id=324762
rdar://188035440
Reviewed by Kimmo Kinnunen.
parseCompositeAndBlendOperator() accepts "darker" and maps it to
CompositeOperator::PlusDarker, but
"darker" is not a valid canvas composite mode per the HTML spec, so assigning
it should be ignored
and leave the previous value in place. Make parseCompositeAndBlendOperator()
fail to parse "darker".
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/compositing/2d.composite.operation.darker-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/compositing/2d.composite.operation.darker-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/compositing/2d.composite.operation.darker.worker-expected.txt:
* Source/WebCore/platform/graphics/GraphicsTypes.cpp:
(WebCore::parseCompositeAndBlendOperator):
Canonical link: https://commits.webkit.org/321811@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
