Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: be499e24a6c074fdde99d63e6defa7a198ad4637
https://github.com/WebKit/WebKit/commit/be499e24a6c074fdde99d63e6defa7a198ad4637
Author: Sammy Gill <[email protected]>
Date: 2026-09-25 (Fri, 25 Sep 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-002.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-003.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-004-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-004.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-005-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-005.html
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
Log Message:
-----------
[GFC][Integration] Allow basic repeat()
https://bugs.webkit.org/show_bug.cgi?id=325177
rdar://182549170
Reviewed by Alan Baradlay.
Style::GridTemplateList already expands repeat() with an integer count into
its list of track sizes, and GFC reads that expanded list for the explicit
track count, the track sizing functions, and line-based placement. So the
integration code was the only thing keeping grids that use repeat() out of
GFC.
Allow repeat(<integer>, ...) in grid-template-columns and grid-template-rows
as long as every entry inside it meets the same rules as a top-level entry:
fixed breadth track sizes and no line names. repeat(auto-fill, ...) and
repeat(auto-fit, ...) are still rejected, since computing the number of
repetitions from the available space is not yet implemented.
Also check the expanded track sizes when looking for percentage rows in a
grid with an indefinite height. Previously only top-level entries were
checked, so repeat(2, 10%) would have been let into GFC.
Tests:
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-002.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-003.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-004.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-integer-005.html
* Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp:
(WebCore::LayoutIntegration::hasUnsupportedGridTrackListEntry): Shared check for
grid-template-columns and grid-template-rows that also looks inside repeat().
Canonical link: https://commits.webkit.org/321911@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
