Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 701aa0c906ca74ce08e3d686a50e565a5b30b31d
https://github.com/WebKit/WebKit/commit/701aa0c906ca74ce08e3d686a50e565a5b30b31d
Author: Chris Dumez <[email protected]>
Date: 2026-09-26 (Sat, 26 Sep 2026)
Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebCore/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebCore/bridge/objc/WebScriptObject.mm
M Source/WebCore/bridge/objc/objc_instance.mm
M Source/WebCore/bridge/objc/objc_runtime.mm
M Source/WebCore/bridge/objc/objc_utility.h
M Source/WebCore/bridge/objc/objc_utility.mm
M Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapCocoa.mm
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLLinkElement.cpp
M Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLTextFormControlElement.cpp
M Source/WebCore/html/ImageBitmap.cpp
M Source/WebCore/html/LinkIconCollector.cpp
M Source/WebCore/html/MediaController.cpp
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/html/ValidatedFormListedElement.cpp
M Source/WebCore/html/ValidationMessage.cpp
M Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp
M Source/WebCore/html/canvas/PlaceholderRenderingContext.h
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/loader/ResourceMonitorPersistence.cpp
M Source/WebCore/page/DragController.cpp
M Source/WebCore/page/mac/ServicesOverlayController.mm
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebCore/platform/cf/KeyedDecoderCF.cpp
M Source/WebCore/platform/cf/KeyedEncoderCF.cpp
M Source/WebCore/platform/graphics/GraphicsLayerContentsDisplayDelegate.h
M Source/WebCore/platform/ios/WebAVPlayerController.mm
M Source/WebCore/platform/mediastream/cocoa/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/cocoa/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp
M Source/WebCore/platform/network/cocoa/ResourceHandleCocoa.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/ServiceWorkerInternals.mm
M Source/WebCore/testing/cocoa/WebViewVisualIdentificationOverlay.mm
Log Message:
-----------
[Safer CPP] Address more warnings in WebCore/
https://bugs.webkit.org/show_bug.cgi?id=325234
Reviewed by Geoffrey Garen.
* Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createContext2d):
(WebCore::HTMLCanvasElement::createContextWebGPU):
(WebCore::HTMLCanvasElement::didUpdateSizeProperties):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::needsPreparationForDisplay):
(WebCore::HTMLCanvasElement::prepareForDisplay):
(WebCore::HTMLCanvasElement::dynamicRangeLimitDidChange):
(WebCore::HTMLCanvasElement::getContextEffectiveDynamicRangeLimitValue const):
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::ExpectIdTargetObserver::ExpectIdTargetObserver):
(WebCore::HTMLLinkElement::attributeChanged):
(WebCore::HTMLLinkElement::mediaAttributeMatches const):
* Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp:
(WebCore::HTMLMaybeFormAssociatedCustomElement::matchesValidPseudoClass const):
(WebCore::HTMLMaybeFormAssociatedCustomElement::matchesInvalidPseudoClass
const):
(WebCore::HTMLMaybeFormAssociatedCustomElement::matchesUserValidPseudoClass
const):
(WebCore::HTMLMaybeFormAssociatedCustomElement::matchesUserInvalidPseudoClass
const):
(WebCore::HTMLMaybeFormAssociatedCustomElement::insertionSteps):
(WebCore::HTMLMaybeFormAssociatedCustomElement::postConnectionSteps):
(WebCore::HTMLMaybeFormAssociatedCustomElement::didMoveToNewDocument):
(WebCore::HTMLMaybeFormAssociatedCustomElement::removingSteps):
(WebCore::HTMLMaybeFormAssociatedCustomElement::attributeChanged):
(WebCore::HTMLMaybeFormAssociatedCustomElement::finishParsingChildren):
(WebCore::HTMLMaybeFormAssociatedCustomElement::didUpgradeFormAssociated):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::handlePlaybackPositionChanged):
(WebCore::HTMLMediaElement::couldPlayIfEnoughData const):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::effectiveSpellcheckAttributeChanged):
* Source/WebCore/html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createCompletionHandler):
(WebCore::ImageBitmap::ImageBitmap):
* Source/WebCore/html/LinkIconCollector.cpp:
(WebCore::LinkIconCollector::iconsOfTypes):
* Source/WebCore/html/MediaController.cpp:
(WebCore::MediaController::buffered const):
(WebCore::MediaController::seekable const):
(WebCore::MediaController::played):
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackStateChangePermitted const):
(WebCore::MediaElementSession::canShowControlsManager const):
(WebCore::MediaElementSession::setHasPlaybackTargetAvailabilityListeners):
(WebCore::MediaElementSession::setPlaybackTarget):
(WebCore::MediaElementSession::targetAvailabilityChangedTimerFired):
(WebCore::MediaElementSession::isPlayingToWirelessPlaybackTarget const):
(WebCore::MediaElementSession::setShouldPlayToPlaybackTarget):
(WebCore::MediaElementSession::playbackTargetPickerWasDismissed):
(WebCore::MediaElementSession::mediaEngineUpdated):
(WebCore::MediaElementSession::updateMediaUsageIfChanged):
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::didUpdateSizeProperties):
(WebCore::OffscreenCanvas::getContext):
(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::commitToPlaceholderCanvas):
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::updateValidity):
(WebCore::ValidatedFormListedElement::restoreFormControlStateIfNecessary):
* Source/WebCore/html/ValidationMessage.cpp:
(WebCore::ValidationMessage::adjustBubblePosition):
* Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp:
(WebCore::PlaceholderRenderingContextSource::setPlaceholderBuffer):
(WebCore::PlaceholderRenderingContextSource::setContentsToLayer):
(WebCore::PlaceholderRenderingContext::surfaceBufferToImageBuffer):
(WebCore::PlaceholderRenderingContext::surfaceBufferToNativeImage):
* Source/WebCore/platform/ios/WebAVPlayerController.mm:
(createWebAVPlayerControllerForwarderClassSingleton):
(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController playerControllerProxy]):
(-[WebAVPlayerController setPlayerControllerProxy:]):
(-[WebAVPlayerController loadedTimeRanges]):
(-[WebAVPlayerController setLoadedTimeRanges:]):
(-[WebAVPlayerController seekableTimeRanges]):
(-[WebAVPlayerController setSeekableTimeRanges:]):
(-[WebAVPlayerController timing]):
(-[WebAVPlayerController setTiming:]):
(-[WebAVPlayerController audioMediaSelectionOptions]):
(-[WebAVPlayerController setAudioMediaSelectionOptions:]):
(-[WebAVPlayerController legibleMediaSelectionOptions]):
(-[WebAVPlayerController setLegibleMediaSelectionOptions:]):
(-[WebAVPlayerController externalPlaybackAirPlayDeviceLocalizedName]):
(-[WebAVPlayerController setExternalPlaybackAirPlayDeviceLocalizedName:]):
(-[WebAVPlayerController minTiming]):
(-[WebAVPlayerController setMinTiming:]):
(-[WebAVPlayerController maxTiming]):
(-[WebAVPlayerController setMaxTiming:]):
(-[WebAVPlayerController play:]):
(-[WebAVPlayerController pause:]):
(-[WebAVPlayerController togglePlayback:]):
(-[WebAVPlayerController setPlaying:]):
(-[WebAVPlayerController setDefaultPlaybackRate:fromJavaScript:]):
(-[WebAVPlayerController setRate:fromJavaScript:]):
(-[WebAVPlayerController beginScrubbing:]):
(-[WebAVPlayerController endScrubbing:]):
(-[WebAVPlayerController seekToTime:]):
(-[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]):
(-[WebAVPlayerController beginScanningForward:]):
(-[WebAVPlayerController endScanningForward:]):
(-[WebAVPlayerController beginScanningBackward:]):
(-[WebAVPlayerController endScanningBackward:]):
(-[WebAVPlayerController seekToBeginning:]):
(-[WebAVPlayerController seekToEnd:]):
(-[WebAVPlayerController setCurrentAudioMediaSelectionOption:]):
(-[WebAVPlayerController setCurrentLegibleMediaSelectionOption:]):
(-[WebAVPlayerController setMuted:]):
(-[WebAVPlayerController toggleMuted:]):
(-[WebAVPlayerController volume]):
(-[WebAVPlayerController setVolume:]):
* Source/WebCore/platform/mediastream/cocoa/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/cocoa/AVVideoCaptureSource.mm:
(WebCore::globaVideoCaptureSerialQueue):
(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::AVVideoCaptureSource::device const):
(WebCore::AVVideoCaptureSource::session const):
(WebCore::AVVideoCaptureSource::maxPhotoSizeForCurrentPreset const):
(WebCore::AVVideoCaptureSource::cameraCaptureDeviceTypes):
(WebCore::AVVideoCaptureSource::facingModeFitnessScoreAdjustment const):
(WebCore::AVVideoCaptureSource::areSettingsMatching const):
(WebCore::AVVideoCaptureSource::setSessionSizeFrameRateAndZoom):
(WebCore::AVVideoCaptureSource::updateWhiteBalanceMode):
(WebCore::AVVideoCaptureSource::updateTorch):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::generatePresets):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::DrawingState::timeFont):
(WebCore::MockRealtimeVideoSource::DrawingState::bipBopFont):
(WebCore::MockRealtimeVideoSource::DrawingState::statsFont):
(WebCore::MockRealtimeVideoSource::drawText):
(WebCore::MockRealtimeVideoSource::imageBufferInternal):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setStrictRawResourceValidationPolicyDisabled):
(WebCore::Internals::disableTileSizeUpdateDelay):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):
(WebCore::Internals::usedOutlineOffset):
(WebCore::Internals::boundingBox):
(WebCore::Internals::markerCountForNode):
(WebCore::Internals::scrollBySimulatingWheelEvent):
(WebCore::Internals::lineIndexAfterPageBreak):
(WebCore::Internals::recentSearches):
(WebCore::Internals::advanceToNextMisspelling):
(WebCore::Internals::nodesFromRect const):
(WebCore::Internals::layerTreeAsText const):
(WebCore::Internals::layerIDForElement):
(WebCore::Internals::verticalScrollbarLayerID const):
(WebCore::Internals::verticalScrollbarFrameRect const):
(WebCore::Internals::scrollCornerRect const):
(WebCore::Internals::scrollingNodeIDForNode):
(WebCore::Internals::scrollableAreaWidth):
(WebCore::Internals::platformLayerTreeAsText const):
(WebCore:: const):
(WebCore::Internals::scrollbarOverlayStyle const):
(WebCore::Internals::scrollbarUsingDarkAppearance const):
(WebCore::Internals::horizontalScrollbarState const):
(WebCore::Internals::verticalScrollbarState const):
(WebCore::Internals::scrollbarsControllerTypeForNode const):
(WebCore::Internals::evaluateInWorldIgnoringException):
(WebCore::Internals::selectionBounds):
(WebCore::Internals::setSelectionWithoutValidation):
(WebCore::Internals::setSelectionFromNone):
(WebCore::Internals::queueMicroTask):
(WebCore::Internals::scrollSnapOffsets):
(WebCore::Internals::isScrollSnapInProgress):
(WebCore::Internals::queueTask):
(WebCore::Internals::queueTaskToQueueMicrotask):
(WebCore::Internals::hasSameEventLoopAs):
(WebCore::Internals::setAlwaysAllowLocalWebarchive):
(WebCore::Internals::testDictionaryLogging):
(WebCore::Internals::highlightPseudoElementColor):
(WebCore::Internals::registerMockMediaSessionCoordinator):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/ServiceWorkerInternals.mm:
(WebCore::ServiceWorkerInternals::processName const):
* Source/WebCore/testing/cocoa/WebViewVisualIdentificationOverlay.mm:
(drawPattern):
Canonical link: https://commits.webkit.org/321976@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
