Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d249df4a2f3ab3b98cf55fd9caca778105ae6be7
https://github.com/WebKit/WebKit/commit/d249df4a2f3ab3b98cf55fd9caca778105ae6be7
Author: Jessica Cheung <[email protected]>
Date: 2026-09-27 (Sun, 27 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TextManipulation.mm
Log Message:
-----------
[Webpage Translation Refactoring] Add ViewportProximityInfo to
_WKTextManipulationItem
https://bugs.webkit.org/show_bug.cgi?id=325243
rdar://188356502
Reviewed by Ryosuke Niwa, Richard Robinson, and Abrar Rahman Protyasha.
Add the ViewportProximityInfo heuristic to
_WKTextManipulationItem.
Additionally, create six new API tests that test:
- ViewportProximity: Checks for Intersecting and Offscreen texts
- ViewportProximityHorizontalDistance: Ensures the distance is
normalized by the viewport width when text is pushed to the side
instead of just downwards.
- ViewportProximityCoverageBounds: Two independent sub-blocks that
test viewportCoverage 1 when text is larger than the viewport and
a fully visible item being greater in coverage than the partially visible item
- ViewportProximityWithSubscroller: Checks for all three ViewportRelations
- ViewportProximityAfterScrollingSubscroller: Tests that the first paragraph
is now ClippedByAncestor since it's scrolled out of sight while the second
paragraph is Intersecting.
- ViewportProximityWithClippingAncestor: Makes sure text in an overflow: hidden
height: 0 div is not actually visible.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(createViewportRelation):
(createViewportProximityInfo):
(-[WKWebView _startTextManipulationsWithConfiguration:completion:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm:
(descriptionForViewportRelation):
(-[_WKTextManipulationViewportProximityInfo
initWithRelation:viewportSizedDistance:viewportCoverage:]):
(-[_WKTextManipulationViewportProximityInfo description]):
(-[_WKTextManipulationItem
initWithIdentifier:tokens:isSubframe:isCrossSiteSubframe:viewportProximityInfo:]):
(-[_WKTextManipulationItem viewportProximityInfo]):
(-[_WKTextManipulationItem _descriptionPreservingPrivacy:]):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TextManipulation.mm:
(TestWebKitAPI::findTextManipulationItems):
(TestWebKitAPI::proximityForItemContaining):
(TestWebKitAPI::TEST(TextManipulation, ViewportProximity)):
(TestWebKitAPI::TEST(TextManipulation, ViewportProximityHorizontalDistance)):
(TestWebKitAPI::TEST(TextManipulation, ViewportProximityCoverageBounds)):
(TestWebKitAPI::TEST(TextManipulation, ViewportProximityWithSubscroller)):
(TestWebKitAPI::TEST(TextManipulation,
ViewportProximityAfterScrollingSubscroller)):
(TestWebKitAPI::TEST(TextManipulation, ViewportProximityWithClippingAncestor)):
Canonical link: https://commits.webkit.org/322016@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
