Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ff517ceb74e260ca87c6ac9fd6c48b4bc9ed5bb
https://github.com/WebKit/WebKit/commit/2ff517ceb74e260ca87c6ac9fd6c48b4bc9ed5bb
Author: Dan Hecht <[email protected]>
Date: 2026-09-28 (Mon, 28 Sep 2026)
Changed paths:
M JSTests/heapProfiler/basic-edges.js
M JSTests/heapProfiler/driver/driver.js
M JSTests/heapProfiler/typed-array-sizes.js
Log Message:
-----------
[JSC] Fix the heap snapshot tests in JSTests/heapProfiler
https://bugs.webkit.org/show_bug.cgi?id=325370
rdar://188478420
Reviewed by Mark Lam.
These tests have never been in run-javascriptcore-tests' collection list, so
they rotted. The
driver still expected snapshot version 2, which every test failed on.
typed-array-sizes.js
counted ArrayBuffer.prototype and SharedArrayBuffer.prototype as ArrayBuffer
instances,
since both prototypes share that class name. basic-edges.js expected objects to
be
collected after being cleared, but top-level calls left copies of them in the
top-level
frame, where the conservative stack scan kept them alive; create and link them
in
helpers instead.
Might enable the tests is a separate change.
* JSTests/heapProfiler/basic-edges.js:
(createSimpleObjects):
(linkSimpleObjects):
* JSTests/heapProfiler/driver/driver.js:
(createCheapHeapSnapshot):
(createHeapSnapshot):
* JSTests/heapProfiler/typed-array-sizes.js:
(excludePrototypes):
Canonical link: https://commits.webkit.org/322065@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
