Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5711bb8106385fec1bcd86caa8fde0ad2b435aa0
https://github.com/WebKit/WebKit/commit/5711bb8106385fec1bcd86caa8fde0ad2b435aa0
Author: Youenn Fablet <[email protected]>
Date: 2026-09-28 (Mon, 28 Sep 2026)
Changed paths:
M Source/WebCore/platform/graphics/cocoa/H264UtilitiesCocoa.mm
M Source/WebCore/platform/graphics/cocoa/HEVCUtilitiesCocoa.mm
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/H264UtilitiesCocoaTests.mm
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/HEVCUtilitiesCocoaTests.mm
Log Message:
-----------
Align H264 and HEVC annexB conversion routines
rdar://188572909
https://bugs.webkit.org/show_bug.cgi?id=325479
Reviewed by Jean-Yves Avenard.
We fix createVideoInfoFromHEVCAnnexBStream to make sure it does not log errors
when there is none, following the H264 corresponding routine.
We fix convertAVCAnnexBToLengthPrefixed to follow its HEVC variant, so that, if
a PPS is not found following the SPS, we do not skip the SPS.
We add API tests to cover this.
Tests: Tools/TestWebKitAPI/Tests/WebCore/cocoa/H264UtilitiesCocoaTests.mm
Tools/TestWebKitAPI/Tests/WebCore/cocoa/HEVCUtilitiesCocoaTests.mm
* Source/WebCore/platform/graphics/cocoa/H264UtilitiesCocoa.mm:
(WebCore::convertAVCAnnexBToLengthPrefixed):
* Source/WebCore/platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:
(WebCore::createVideoInfoFromHEVCAnnexBStream):
(WebCore::convertHEVCAnnexBToLengthPrefixed):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/H264UtilitiesCocoaTests.mm:
(TestWebKitAPI::TEST(H264UtilitiesCocoa,
CreateVideoInfoFromAnnexBReturnsNullptrWhenSpsIsNotFollowedByPps)):
(TestWebKitAPI::TEST(H264UtilitiesCocoa,
ConvertsAnnexBToLengthPrefixedKeepsSpsWhenPpsMissing)):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/HEVCUtilitiesCocoaTests.mm:
(TestWebKitAPI::TEST(HEVCUtilitiesCocoa,
CreateVideoInfoFromAnnexBReturnsNullptrForSpsOnlyFrame)):
(TestWebKitAPI::TEST(HEVCUtilitiesCocoa,
ConvertsAnnexBToLengthPrefixedKeepsAllNalusWhenVpsMissing)):
(TestWebKitAPI::TEST(HEVCUtilitiesCocoa,
CreateVideoInfoFromAnnexBReturnsNullptrWhenVpsNotFollowedBySpsAndPps)):
(TestWebKitAPI::TEST(HEVCUtilitiesCocoa,
ConvertsAnnexBToLengthPrefixedKeepsVpsWhenSpsAndPpsMissing)):
Canonical link: https://commits.webkit.org/322135@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
