Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 28208949796c162fc995cb624bf6631a1a8428df
https://github.com/WebKit/WebKit/commit/28208949796c162fc995cb624bf6631a1a8428df
Author: Brady Eidson <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Adding an app highlight in a cross-origin iframe does
nothing (and can later crash the UI process)
rdar://188667880
https://bugs.webkit.org/show_bug.cgi?id=325598
Reviewed by Anne van Kesteren.
Two parts to the fix:
1 - Send the message to the appropriate process
2 - WebContent processes always need to reply instead of leaving the UI process
hanging.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::createAppHighlightInSelectedRange):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createAppHighlightInSelectedRange):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(-[SiteIsolationAppHighlightDelegate init]):
(-[SiteIsolationAppHighlightDelegate
_webView:storeAppHighlight:inNewGroup:requestOriginatedInApp:]):
(-[SiteIsolationAppHighlightDelegate storedHighlights]):
(TestWebKitAPI::TEST(SiteIsolation, AddAppHighlightInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
AddAppHighlightWithoutSelectionDoesNotCrashWhenWebProcessesExit)):
Canonical link: https://commits.webkit.org/322155@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
