Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e3c21113c44785a47ebf36cdd8095058712501ec
https://github.com/WebKit/WebKit/commit/e3c21113c44785a47ebf36cdd8095058712501ec
Author: Charlie Wolfe <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
Log Message:
-----------
Avoid creating hidden media controls for inline videos that require
fullscreen playback
https://bugs.webkit.org/show_bug.cgi?id=325577
rdar://188655046
Reviewed by Jean-Yves Avenard.
configureMediaControls() always created media controls for a video whose
session requires fullscreen
playback, even while it was inline, so the controls could never be shown. Only
require them once the
video is presented in fullscreen or picture-in-picture. Entering video
fullscreen already calls
configureMediaControls() after updating the fullscreen mode, so controls are
still created when
they're needed.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureMediaControls):
Canonical link: https://commits.webkit.org/322163@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
